Jump to content

[uvm_report_handler.svh] there seems to have redundant code in uvm1-1a


Recommended Posts

it is not harmful, however, I am not sure if it has been reported. just leave a copy here for your reference. in uvm_report_handler.svh, the id_file_handles and severity_file_handles are checked twice, the later one could never be coded.

in the get_file_handle();

file = get_severity_id_file(severity, id);
    if (file != 0)
      return file;
  
    if (id_file_handles.exists(id)) begin
      file = id_file_handles.get(id);
      if (file != 0)
        return file;
    end

    if (severity_file_handles.exists(severity)) begin
      file = severity_file_handles[severity];
      if(file != 0)
        return file;
    end

in the get_severity_id_file();

if(id_file_handles.exists(id))
      return id_file_handles.get(id);

    if(severity_file_handles.exists(severity))
      return severity_file_handles[severity];

    return default_file_handle;
Link to comment
Share on other sites

I found another some redundant code in uvm_sequence_base.svh, the lower 2 if statements should be no needed since its already uvm_fatal.

    if (sequencer == null)
        sequencer = item.get_sequencer();
        
    if(sequencer == null)
        sequencer = get_sequencer();   
        
    if(sequencer == null) begin
        uvm_report_fatal("SEQ",{"neither the item's sequencer nor dedicated sequencer has been supplied to start item in ",get_full_name()},UVM_NONE);
       return;
    end
      
    if (sequencer == null)
      sequencer = item.get_sequencer();
    
    if (sequencer == null) begin
        uvm_report_fatal("STRITM", "sequence_item has null sequencer", UVM_NONE);
    end
Link to comment
Share on other sites

A while ago I found the mantis permits only commitee members to post. so I could not register an account yet. Thanks to Uwe anyway.

we can clarify if only committee members can file mantis items. in the meantime please raise any suspicious behaviour here in the uvmworld forums. the forums are monitored by committee members which have in the past filed mantis items on the posters behalf.

/uwe

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...