Bug in sc_name_gen.cpp

[madmax]

Hello,

I believe there is a bug in sc_name_gen.cpp, function sc_name_gen::gen_unique_name. It's possible that one sc_name_gen instance generates the same name twice in cases where the "preserve_first" flag is set to true, and the basename already contains a "_N" postfix. Example:

sc_gen_unique_name("bla", true);   // -> "bla"
sc_gen_unique_name("bla", true);   // -> "bla_1"
sc_gen_unique_name("bla_1", true); // -> "bla_1"

The bug should be present on all versions. I also noticed that the "preserve_first" functionality is not mentioned in the standard at all.

Thanks and Regards,

Max

[David Black]

If something is not mentioned in the standard, then you should assume it's an internal implementation thing and not to be used by the end-user.

Use the syntax of the standard and don't use the syntax of the implementation as your guide.

The bug is likely that somebody provided an extra parameter at all.