Jump to content
sumit_tuwien

SC_CSD in src/sysc/datatypes/int/sc_nbutils.h

Recommended Posts

In sc_nbutils.h  

 

 

inline
void
is_valid_base(sc_numrep base)
{
  switch (base) {
    case SC_NOBASE: case SC_BIN: 
    case SC_OCT: case SC_DEC: 
    case SC_HEX: 
        break;
    case SC_BIN_US: case SC_BIN_SM: 
    case SC_OCT_US: case SC_OCT_SM:
    case SC_HEX_US: case SC_HEX_SM:
      SC_REPORT_ERROR( sc_core::SC_ID_NOT_IMPLEMENTED_,
      "is_valid_base( sc_numrep base ) : "
      "base ending in _US and _SM is not supported yet" );
    default:
      char msg[BUFSIZ];
      std::sprintf( msg, "is_valid_base( sc_numrep base ) : "
      "base = %s is not valid",
      to_string( base ).c_str() );
      SC_REPORT_ERROR( sc_core::SC_ID_VALUE_NOT_VALID_, msg );
  }
}

 

 

SC_CSD case is missing and will default. Is this fine ?
 
Regards, Sumit
 
 

Share this post


Link to post
Share on other sites

Sumit,

 

thanks for reporting this.
 

In sc_nbutils.h 

inline void is_valid_base(sc_numrep base)
SC_CSD case is missing and will default. Is this fine ?
 
This part of the code is not used from within the standard API.  Thus, I think it may be Ok to have this missing currently.
If we'd wanted to fix this, we probably should add SC_CSD to the "not yet implemented" case here (to be safe).
The proof-of-concept implementation of the standardised API uses other parts of the library for string conversions (including SC_CSD).
 
Greetings from Oldenburg,
  Philipp

 

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


×
×
  • Create New...